Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #649. 'git branch' unknown '--quiet' option was removed. #657

Closed
wants to merge 1 commit into from
Closed

Conversation

bsalex
Copy link

@bsalex bsalex commented Feb 12, 2015

Fix for issue #649

@ljharb
Copy link
Member

ljharb commented Feb 12, 2015

This was added intentionally. What version of git are you using such that --quiet is not an option? You should be on v2.2.1 or higher due to security issues https://github.com/blog/1938-git-client-vulnerability-announced

@bsalex
Copy link
Author

bsalex commented Feb 12, 2015

I'm using v1.7.1.
Unfortunately I have no permissions to upgrade it.

@ljharb
Copy link
Member

ljharb commented Feb 12, 2015

I'd prefer to add an explicit version check so that git isn't auto-selected as an install option when the git version isn't high enough. Still using git v1.7.1 is like still using IE 6, so I don't wish to support it.

@ljharb ljharb closed this Feb 15, 2015
@ljharb
Copy link
Member

ljharb commented Feb 15, 2015

@bsalex Thanks for the PR! The effort is definitely appreciated even when a change doesn't end up landing.

If you'd like to submit a PR that gives a more useful error message, or avoids the git install method when --quiet is not supported, I'd love to accept that.

@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Apr 22, 2015
ljharb added a commit that referenced this pull request Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants