Only filter the package npm, not any package name contains 'npm' #690
Conversation
|
@hax Thanks, great catch! Can you also modify the tests so they would have caught this? |
|
It seems there are some other bugs because it report failure when I run tests on my laptop... I will try it on a clean vm later. |
|
Thanks - also feel free to push, and let |
| @@ -6,16 +6,17 @@ die () { echo "$@" ; exit 1; } | |||
|
|
|||
| nvm use 0.10.28 | |||
|
|
|||
| EXPECTED_PACKAGES="autoprefixer bower david eslint grunt-cli grunth-cli http-server jshint marked node-gyp recursive-blame uglify-js yo" | |||
| EXPECTED_PACKAGES="autoprefixer bower david eslint grunt-cli grunth-cli http-server jshint marked node-gyp npmlist recursive-blame uglify-js yo" | |||
There was a problem hiding this comment.
Does npmlist require grunt-cli, which requires a new version of node? The tests run with 0.10 at the moment. Could we use another package that doesn't have those kind of requirements?
There was a problem hiding this comment.
npmlist use gulp not grunt.
There was a problem hiding this comment.
Ah, then I'm not sure why the tests failed
There was a problem hiding this comment.
Just because I'm not familiar with shell programming...
|
Thanks for bearing with me! If the tests pass, please rebase this, freshly on top of master, down to no more than two commits (one for the test, one for the implementation) or one (for both), and I'll merge it. Your contribution is appreciated! |
|
Almost there - rebasing it on top of the latest master should remove my two commits from your PR. |
Only filter the package `npm`, not any package name that contains 'npm'
|
@hax Thanks for the contribution! |
|
There is still a problem -- should redo |
No description provided.