Improve startup performance. Closes #703 #705
Conversation
|
I added a comment re |
| @@ -1718,7 +1724,7 @@ if nvm_supports_source_options && [ "_$1" = "_--install" ]; then | |||
| elif nvm_rc_version >/dev/null 2>&1; then | |||
| nvm install >/dev/null | |||
| fi | |||
| elif nvm ls default >/dev/null; then | |||
| elif nvm_alias default >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Looks like some of the tests failed :-/ I suspect this line is the issue.
There was a problem hiding this comment.
I'm unsure; I'm having some trouble with the test suite (#708).
Edit: I think the line might be OK actually.
|
@joliss ping :-) |
| "_default") | ||
| # Special case for performance, as this is run on every shell startup | ||
| VERSION="$(nvm_alias default 2> /dev/null)" | ||
| ;; |
There was a problem hiding this comment.
This actually turns out not to work correctly when the default alias is itself a symbol like "iojs" that needs to be resolved further.
|
Okay, Travis passes now. I had to remove some stuff; see my comment on outdated diff above. I think it's good to merge! The other issues probably require someone to dig a bit deeper and fix the performance issues properly; I wrote up some findings at #709, but don't want to try and fix things at this point, as I don't know the code well enough. |
Improve startup performance. Closes #703
|
Thanks! I'll take a look at #709 as well. |
No description provided.