Consolidate and avoid sed/cut calls, clean up pattern matches #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local NVM_NUM_DOTS | ||
| NVM_NUM_DOTS=$(echo "$VERSION" | command sed -e 's/[^\.]//g') | ||
| NVM_NUM_DOTS="${VERSION//[^.]/}" |
There was a problem hiding this comment.
I'm afraid this form of substitution is not an option as it doesn't work in dash/sh - this will fail tests.
There was a problem hiding this comment.
Ah yes. I've reverted this one.
| VERSION="${VERSION#v*}" | ||
| VERSION="${VERSION%\.}" | ||
| VERSION="${VERSION#v}" | ||
| VERSION="${VERSION%.}" |
There was a problem hiding this comment.
I've made a functionality change here so that "v" and "." report 0 in c34502e, and incorporated these changes there. Apologies for the merge conflict :-/ a fresh rebase should sort it?
There was a problem hiding this comment.
Done; build is green now!
Some patterns contained a no-op `*`; the `*` would match the empty string because # or % replacement (unlike ## or %%) tries to find the shortest match.
ljharb
added a commit
that referenced
this pull request
Apr 7, 2015
Consolidate and avoid sed/cut calls, clean up pattern matches
|
Thanks! |
|
Are there tests for this? |
|
This commit hasn't been released yet, so your other issue wouldn't possibly be affected by it. But yes, there are tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some patterns contained a no-op
*; the*would match the empty stringbecause # or % replacement (unlike ## or %%) tries to find the shortest match.
(Follow up to #709.)