adding architecture detection for Raspberry Pi 2 #742
Conversation
|
Thanks for the contribution! This is definitely very tricky to write tests for, so we may not need them. My concern is older versions of It's highly likely that this will just make Another option would be |
ljharb
added
OS: Raspberry Pi
installing node
|
Are you wanting these manual tests on non-Pi machines, or on my Pi? The issue was that it was trying to download https://nodejs.org/dist/v0.11.9/node-v0.11.9-linux-arm7l.tar.gz instead of https://nodejs.org/dist/v0.11.9/node-v0.11.9-linux-arm-pi.tar.gz. |
|
You're right - since the issue is about which tarball is downloaded, the only concern here would be if an Since it appears there isn't any |
|
I wrote a script to dig into all the nodejs.org/dist/v0../ folders and look for arm.tar.gz and I don't see any other than arm-pi. [ '/dist/v0.10.0/node-v0.10.0-linux-arm-pi.tar.gz', |
adding architecture detection for Raspberry Pi 2
I have no idea how to write tests for this. I have about 3hrs of linux/RPi experience, but I know that my Raspberry Pi 2 reports an architecture of armv7l whereas nvm currently only detects armv6l as a Raspberry Pi. I made this change on my machine and it worked, so I am contributing my changes. :-) Hopefully they help.
If you want to give me a little direction on how to write and run tests I can try to help out with that also. :-)