Detect shell type from $SHELL variable instead of .$SHELLrc files #765

CristianCantoro · 2015-06-12T17:00:05Z

As per commit message.
I am using zsh on Ubuntu, but I am keeping also the default .bashrc that gets shipped with Ubuntu in my home folder. As of now, the nvm "loading" configuration gets added to $HOME/.bashrc because the check on .bashrc is encountered before the check on .zshrc.

basename is part of the GNU coreutils so it should be widely available and this should work also on other OSes.

Testing the various shells

(sh is dash on my system)

Launch from zsh

[~/extra/nvm/nvm]$ cat ./install.sh | sh
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Appending source string to /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

Launch from bash

$ bash
cristian@wash:~/extra/nvm/nvm$ cat ./install.sh | sh
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

Launch from ksh

$ ksh
$ cat ./install.sh | sh
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 1.41 MiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

Launch from sh

$ sh
$ cat ./install.sh | sh
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ljharb · 2015-06-12T17:02:02Z

Thanks for the contribution!

I am all for improving profile file detection as there's a number of issues open about it. I'm concerned about changing this though, so I'll want to test it on as many configurations as possible before merging it.

ljharb · 2015-06-12T17:15:51Z

(Note that install.sh must be piped to bash, not sh, and that this has to work correctly with all of zsh, bash, dash, sh, and ksh)

CristianCantoro · 2015-06-12T17:30:34Z

@ljharb, I had also tested that possibility, but omitted it before.

Anyway, I believe that even launching the script from dash (i.e. ... install.sh | sh) gets it executed in bash because of the #!/bin/bash line at the beginning of the script (but I may be wrong, this things are always more complicated than they seem).

Also note that since my $SHELL env variable remains the same even when I launch a different shell the profile detected remains .zshrc, which is the intended behaviour, IMHO.

Here's the test executing the script with bash.

Piping to bash

zsh

[~/extra/nvm/nvm]$ cat ./install.sh | bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

bash

$ bash
cristian@wash:~/extra/nvm/nvm$ cat ./install.sh | bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ksh

$ ksh
$ cat ./install.sh | bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

sh (dash)

$ sh
$ cat ./install.sh | bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ljharb · 2015-06-12T17:32:26Z

What about on a Mac, where by default, bashrc isn't sourced, and bash_profile is? On a fresh Mac user account I suspect this will break. Perhaps you want to also check for the file's existence as well as the shell type?

CristianCantoro · 2015-06-12T18:22:17Z

@ljharb, I have changed my pull request and rebased.

Here's the test.

Piping to sh

zsh to sh

zsh -c "cat /home/cristian/extra/nvm/nvm/install.sh | sh; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 1.48 MiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

bash to sh

bash -c "cat /home/cristian/extra/nvm/nvm/install.sh | sh; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 1.27 MiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ksh to sh

ksh -c "cat /home/cristian/extra/nvm/nvm/install.sh | sh; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 653.00 KiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

sh to sh

sh -c "cat /home/cristian/extra/nvm/nvm/install.sh | sh; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

Piping to bash

zsh to bash

zsh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

bash to bash

bash -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ksh to bash

ksh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

sh to bash

sh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 651.00 KiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.zshrc
=> Close and reopen your terminal to start using nvm

ljharb · 2015-06-12T18:23:52Z

Why are "bash to bash" and "ksh to bash" both doing "Source string already in /home/cristian/.zshrc"?

CristianCantoro · 2015-06-12T18:26:50Z

@ljharb because the $SHELL env variable does not change if you launch the script with another shell. As I said above this is the intended behaviour otherwise when you do ... ./install.sh | bash it would use .bashrc which should not be the case.

ljharb · 2015-06-12T18:28:07Z

Right but shouldn't "bash to bash", to be a useful test, have $SHELL set such that it's bash?

CristianCantoro · 2015-06-12T19:29:11Z

Setting the $SHELL variable to /bin/bash with export SHELL="/bin/bash";

Setting $SHELL to bash

zsh to bash

echo "My shell is: $SHELL"; zsh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
My shell is: /bin/bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 1.17 MiB/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.bashrc
=> Close and reopen your terminal to start using nvm

bash to bash

echo "My shell is: $SHELL"; bash -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
My shell is: /bin/bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.bashrc
=> Close and reopen your terminal to start using nvm

ksh to bash

echo "My shell is: $SHELL"; ksh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
My shell is: /bin/bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.bashrc
=> Close and reopen your terminal to start using nvm

sh to bash

echo "My shell is: $SHELL"; sh -c "cat /home/cristian/extra/nvm/nvm/install.sh | bash; rm -rf "/home/cristian/.nvm";  exit;"
My shell is: /bin/bash
=> Downloading nvm from git to '/home/cristian/.nvm'
=> Cloning into '/home/cristian/.nvm'...
remote: Counting objects: 3693, done.
remote: Total 3693 (delta 0), reused 0 (delta 0), pack-reused 3693
Receiving objects: 100% (3693/3693), 827.00 KiB | 0 bytes/s, done.
Resolving deltas: 100% (2132/2132), done.
Checking connectivity... done.
* (detached from v0.25.4)
  master

=> Source string already in /home/cristian/.bashrc
=> Close and reopen your terminal to start using nvm

ljharb · 2015-06-12T19:30:11Z

lol, now your zsh to bash test says "Source string already in /home/cristian/.bashrc"

ljharb · 2015-06-12T19:30:45Z

Please do also add/modify the automated install_script tests for this new behavior.

CristianCantoro · 2015-06-12T19:55:13Z

@ljharb it was already there exactly because when I tried the first install it added the line in .bashrc! (and yes, if you change your SHELL variable that's exactly what it should happen).

Anyhow, the important thing is the shell interpreter that is on the right hand side of the pipe (and so far I have tested it with sh/dash and bash because the left part basically just concatenates the output. (also, I was wrong above, even if you specify #!/bin/bash at the beginning of the script it gets executed with the shell interpreter that you specify on the right hand side.

dfreeman · 2015-07-08T01:55:45Z

I'd love to see this change (or something similar) land. Is there anything I can do to help out in terms of verifying various shell combinations?

ljharb · 2015-07-08T03:59:56Z

@dfreeman #765 (comment) and #765 (comment) are my latest comments. If @CristianCantoro is unavailable, unable, or unwilling to complete the PR, I'd say it's a great idea to cherry-pick his commits into your own branch, and complete it as a new PR! :-)

dfreeman · 2015-07-08T04:03:02Z

Oops! That's what I get for skimming up and down the comment thread too quickly :)
Next time I've got a little time free, I'll see about pulling @CristianCantoro's initial work over into a fresh PR and wrapping it up (if he doesn't get to it in the meantime). Thanks!

CristianCantoro · 2015-07-08T07:52:19Z

@dfreeman, @ljharb I am not 100% sure that the ksh install script is working 100%, I will double check that and see if I need to report an issue.

ljharb · 2015-07-08T12:49:48Z

Thanks - I had to disable the ksh tests awhile back, so it's possible/likely there's an issue there.

CristianCantoro · 2015-07-17T11:58:56Z

Added the test and rebased the commit. Please note that I have also moved .profile higher in the priority for seaching dotfiles because this is a more sensible setting for people that have a $SHELL different from bash or zsh. The latter enjoy the advantage of having their shell detected directly and so for bash users the setting goes directly to .bashrc or .bash_profile. Analogously for zsh users the setting goes to .zshrc.

ljharb · 2015-07-18T16:34:25Z

install.sh

-  elif [ -f "$HOME/.profile" ]; then
-    echo "$HOME/.profile"
+
+  DETECTED_PROFILE=''


Would you mind adding:

local DETECTED_PROFILE local SHELLTYPE

and re-rebasing, to avoid global var pollution?

Done in bc91bc5.

ljharb · 2015-07-18T16:36:32Z

I notice that when I start in bash, and then run zsh, $SHELL remains /bin/bash, but $0 is zsh.

Detecting the current shell is difficult, but I wonder if we could somehow use $0 (probably in the root of install.sh, not in a function) to more accurately detect the current shell?

CristianCantoro · 2015-07-18T18:12:13Z

@ljharb it seems the intended behaviour to me. If you want to change your shell you should use chsh. I want to detect the user default (favourite?) shell, not necessarily the current shell.

ljharb · 2015-07-18T18:16:55Z

Both for testing, and expectations, I'd expect that if i run the install script in X, it installs in X, even if that's not my default.

The current behavior is definitely attempting to detect the default, but I don't think that's quite as useful - since "install into the current shell" will match the default in most cases anyways.

CristianCantoro · 2015-07-18T18:46:44Z

I am not sure of what would be the benefit of adding the configuration to a shell different from your default.
After all, after the installation, if you want to use nvm you still need to (either):

fire up a new shell (the new shell will be your default $SHELL)
source your .$SHELLrc file (works only if you are using your default shell (and only for bash and zsh, since ksh does not have a .kshrc file))
source .profile (works for every shell, if the configuration was added to .profile)
Execute the following command export NVM_DIR="$HOME/.nvm"; [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" (works for every shell)

the instructions also suggest to => Close and reopen your terminal to start using nvm

All in all it seems more useful to me that the configuration line gets added only to the default .$SHELLrc file (adding it in .profile would work for every shell, but I would rather have it added to a more specialized .$SHELLrc file if it is avaiable). If I am using bash as default and I am using zsh only for this session I may even have an empty .zshrc.
Finally, I also expect that people using a shell different from their default one know what they are doing. I do not see why (or how) one should expect that the configuration gets added to the current shell and then lose that configuration when they launch a new shell (or reboot, for example).

ljharb · 2015-07-18T21:06:37Z

install.sh

-  elif [ -f "$HOME/.profile" ]; then
-    echo "$HOME/.profile"
+
+  local DETECTED_PROFILE=''


the local declaration, and the variable assignment, unfortunately need to be on separate lines to ensure compatibility with ksh. see lines 87-90 for an example.

Done in 5f6f55f.

ljharb · 2015-07-18T21:07:54Z

Fair point. When I run zsh from my default bash tho, it does source .zshrc, and thus loads nvm for me (because i'd manually added those lines previously). It'd be really convenient to do zsh && ./install.sh && dash && ./install.sh && bash && ./install.sh && sh && ./install.sh && ksh && ./install.sh etc to set up all my shells.

CristianCantoro · 2015-07-18T23:33:37Z

@ljharb, yes, also on ubuntu .zshrc get loaded when launch zsh, and similarly .bashrc gets loaded whrn launching bash (.bash_profile does not get loaded, nor .profile (this, at least on Ubuntu))

I see what you mean for the installation. What about adding a different profile detection function if the configuration is already detected in the profile file?

ljharb · 2015-07-18T23:49:49Z

I'd be totally fine with two modes of profile detection, "default" and "current". We can do that in a separate PR tho.

CristianCantoro · 2015-07-21T16:02:42Z

Ok, so can we merge this PR? :)
Then I will look into implementing nvm_detect_default_profile and a nvm_detect_current_profile functions.

Detect shell type from $SHELL variable instead of .$SHELLrc files

ljharb · 2015-07-21T23:41:04Z

Done, thanks!

ljharb added the installing nvm: profile detection Issues with nvm's own install script, related to figuring out the right profile file. label Jun 12, 2015

CristianCantoro force-pushed the master branch from 10f9820 to f98d00e Compare June 12, 2015 18:14

CristianCantoro force-pushed the master branch 2 times, most recently from 0131cc0 to 935f5df Compare July 17, 2015 11:56

CristianCantoro force-pushed the master branch from 935f5df to f1dc39b Compare July 17, 2015 12:30

ljharb reviewed Jul 18, 2015
View reviewed changes

CristianCantoro force-pushed the master branch from f1dc39b to bc91bc5 Compare July 18, 2015 18:16

ljharb reviewed Jul 18, 2015
View reviewed changes

CristianCantoro force-pushed the master branch from bc91bc5 to 5f6f55f Compare July 18, 2015 23:21

CristianCantoro force-pushed the master branch from 5f6f55f to 664b654 Compare July 19, 2015 00:02

Detect shell type from $SHELL variable instead of .$SHELLrc files

c37dbbe

CristianCantoro force-pushed the master branch from 664b654 to c37dbbe Compare July 19, 2015 00:03

ljharb added a commit that referenced this pull request Jul 21, 2015

Merge pull request #765 from CristianCantoro/master

1f679fc

Detect shell type from $SHELL variable instead of .$SHELLrc files

ljharb merged commit 1f679fc into nvm-sh:master Jul 21, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect shell type from $SHELL variable instead of .$SHELLrc files #765

Detect shell type from $SHELL variable instead of .$SHELLrc files #765

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

dfreeman commented Jul 8, 2015

ljharb commented Jul 8, 2015

dfreeman commented Jul 8, 2015

CristianCantoro commented Jul 8, 2015

ljharb commented Jul 8, 2015

CristianCantoro commented Jul 17, 2015

ljharb Jul 18, 2015

CristianCantoro Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb Jul 18, 2015

CristianCantoro Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 21, 2015

ljharb commented Jul 21, 2015

Detect shell type from $SHELL variable instead of .$SHELLrc files #765

Detect shell type from $SHELL variable instead of .$SHELLrc files #765

Conversation

CristianCantoro commented Jun 12, 2015

Testing the various shells

Launch from zsh

Launch from bash

Launch from ksh

Launch from sh

ljharb commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

Piping to bash

zsh

bash

ksh

sh (dash)

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

Piping to sh

zsh to sh

bash to sh

ksh to sh

sh to sh

Piping to bash

zsh to bash

bash to bash

ksh to bash

sh to bash

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

Setting $SHELL to bash

zsh to bash

bash to bash

ksh to bash

sh to bash

ljharb commented Jun 12, 2015

ljharb commented Jun 12, 2015

CristianCantoro commented Jun 12, 2015

dfreeman commented Jul 8, 2015

ljharb commented Jul 8, 2015

dfreeman commented Jul 8, 2015

CristianCantoro commented Jul 8, 2015

ljharb commented Jul 8, 2015

CristianCantoro commented Jul 17, 2015

ljharb Jul 18, 2015

Choose a reason for hiding this comment

CristianCantoro Jul 18, 2015

Choose a reason for hiding this comment

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb Jul 18, 2015

Choose a reason for hiding this comment

CristianCantoro Jul 18, 2015

Choose a reason for hiding this comment

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 18, 2015

ljharb commented Jul 18, 2015

CristianCantoro commented Jul 21, 2015

ljharb commented Jul 21, 2015