Adding --silent option for nvm use, and using it to disable processing certain output to speed up shell startup #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng nvm.sh, a considerable amount of time is spent running npm --version only for that output to be black-holed to /dev/null
|
Interesting solution! I think I'd prefer a |
|
I like that better. Definitely cleaner than the global. I'll see what I can whip up. |
alanmquach
changed the title
…things like curl)
|
This is great - could you also add some test cases for this flag? |
|
I added extra cases to the existing tests instead of creating a new file dedicated to "--silent"; felt more maintainable this way. |
ljharb
added a commit
that referenced
this pull request
Jul 18, 2015
Adding --silent option for nvm use, and using it to disable processing certain output to speed up shell startup Relates to #781.
|
Thanks, merged! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sourcing nvm.sh, a considerable amount of time is spent running npm --version only for that output to be black-holed to /dev/null