Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage string for --reinstall-packages-from #797

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Add usage string for --reinstall-packages-from #797

merged 1 commit into from
Aug 6, 2015

Conversation

Sequoia
Copy link
Contributor

@Sequoia Sequoia commented Aug 6, 2015

@reybango added docs for this switch in the readme in #795. I attempted to add similar info in the nvm help usage output. Currently there's no clear format for documenting command switches in this help output (there's another, --copy-packages-from that I didn't add info for). If the style I used here is not acceptable that's fine, it can just be a starting point for discussion of how to doc some of these undocumented switches. 🌴

@ljharb
Copy link
Member

ljharb commented Aug 6, 2015

copy-packages and copy-packages-from are old/deprecated aliases for reinstall-packages etc, so it's good not to document those :-)

This looks great - and you're right, there's no clear format - but what you chose seems good enough for me. Thanks!

@@ -1186,6 +1186,7 @@ nvm() {
echo " nvm help Show this message"
echo " nvm --version Print out the latest released version of nvm"
echo " nvm install [-s] <version> Download and install a <version>, [-s] from source. Uses .nvmrc if available"
echo " --reinstall-packages-from=<version> When installing, reinstall packages installed in <node|iojs|node version number>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node|iojs|node version number isn't entirely accurate, but perhaps (in a separate PR) we should add a line or two above "Usage" explaining what a "version-ish" is (like a commit-ish in git), and then use that term in the command docs whenever it applies.

I'm not attached to the name "version-ish" so other suggestions would be welcome.

ljharb added a commit that referenced this pull request Aug 6, 2015
Add usage string for --reinstall-packages-from
@ljharb ljharb merged commit c07838f into nvm-sh:master Aug 6, 2015
ljharb added a commit to ljharb/nvm that referenced this pull request Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants