Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support aarch64 arch (apple silicon) #57

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

djukxe
Copy link
Contributor

@djukxe djukxe commented Nov 26, 2023

Fixes #
#56
and eventually:
nvuillam/npm-groovy-lint#296
nvuillam/vscode-groovy-lint#163

Proposed Changes

add arm64 arch (referenced as aarch64 on adoptium.net) to the list of supported architecture.

I don't know how to test it but it should work and not impact other architectures detection. I have access to apple silicon mac so I should be able to test when it will be used by java-caller or npm-groovy-lint

example of links you get when you browse adoptium
from apple silicon mac
https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.1%2B12/OpenJDK21U-jdk_aarch64_mac_hotspot_21.0.1_12.tar.gz
from intel mac
https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.1%2B12/OpenJDK21U-jdk_x64_mac_hotspot_21.0.1_12.tar.gz

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, at worse it's not risky for other cases ;)
Thanks for your contribution !

@nvuillam nvuillam merged commit 9467ee0 into nvuillam:master Nov 26, 2023
2 checks passed
@djukxe djukxe deleted the master branch December 2, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants