Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using --javaexecutable in Linux #23

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

Sickafant
Copy link
Contributor

There is a restriction on --javaexecutable usage for platforms other than Windows, due to logic checking for usage of '.exe'. To allow other platforms to specify their java executable and skip the version detection the way Windows can, adjust the condition for the version check.

Exposes an easy workaround for #18

Proposed Changes

  1. Use of --javaexecutable to bypass the version detection is possible with windows, but not in platforms where java binary is not named java.exe. Adjust the conditions so that version detection and autodownload can be skipped when a user passes in an explicit java binary they want to use.
  2. Ultimately want to be able to use this change with npm-groovy-lint

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

There is a restriction on --javaexecutable usage for platforms other
than Windows, due to logic checking for usage of '.exe'. To allow other
platforms to specify their java executable and skip the version
detection the way Windows can, adjust the condition for the version
check.
@Sickafant Sickafant mentioned this pull request Nov 9, 2022
@nvuillam nvuillam self-assigned this Nov 9, 2022
Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your update :)
I'll manage the dependency issue before releasing a new version

@nvuillam nvuillam merged commit 708e1b3 into nvuillam:master Nov 9, 2022
@nvuillam
Copy link
Owner

nvuillam commented Nov 9, 2022

@Sickafant v2.6.0 has been released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants