Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable windows verbatim arguments #47

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Nov 25, 2023

Add support for configuring windowsVerbatimArguments on run to make it easier to create cross platform compatible code.

Also:

  • Add missing run options to README
  • Fix some documentation lint warnings
  • Add missing prettier to dev dependencies
  • Update CHANGELOG.md

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86f79cc) 90.41% compared to head (82db039) 90.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   90.41%   90.45%   +0.04%     
==========================================
  Files           3        3              
  Lines         219      220       +1     
==========================================
+ Hits          198      199       +1     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add support for configuring windowsVerbatimArguments on run to make it
easier to create cross platform compatible code.

Also:
* Add missing run options to README
* Fix some documentation lint warnings
* Add missing prettier to dev dependencies
* Update CHANGELOG.md
Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as usual, thanks :)

@nvuillam nvuillam merged commit 66647ff into nvuillam:main Nov 25, 2023
1 check passed
@nvuillam
Copy link
Owner

nvuillam commented Nov 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants