Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of windowless (javaw) option #66

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

SotirisVas
Copy link
Contributor

Added a new option to call "javaw" instead of "java", only for Windows as Unix does not need this utility.

Fixes #65

Proposed Changes

  1. Add new option for windowless
  2. If true, javaExe becomes javaw
  3. Check if caller platform is actually Windows, if true then use javaw, used for cross-platform compatibility
  4. Added changelog entry and documentation for the option

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Added a new option to call "javaw" instead of "java", only for Windows
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3292af6) 90.45% compared to head (2041a78) 90.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   90.45%   90.54%   +0.08%     
==========================================
  Files           3        3              
  Lines         220      222       +2     
==========================================
+ Hits          199      201       +2     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your PR :)

I'll solve MegaLinter issues in another one

@nvuillam nvuillam merged commit 74e1c84 into nvuillam:main Jan 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to use javaw.exe instead of java.exe
3 participants