Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.EOL #65

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Use os.EOL #65

merged 1 commit into from
Jul 9, 2020
+50 −26

Conversation

nvuillam
Copy link
Owner

@nvuillam nvuillam commented Jul 8, 2020

  • Use os.EOL (#65) solving (#63) --fix for indentation adds CRLF line-endings to all files it touches

Closes #63

@nvuillam nvuillam force-pushed the FixEOL branch 3 times, most recently from f42dfac to 0ab97ed Compare July 9, 2020 10:07
@codecov-commenter
Copy link

Codecov Report

Merging #65 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   93.19%   93.23%   +0.03%     
==========================================
  Files          73       73              
  Lines        1866     1876      +10     
==========================================
+ Hits         1739     1749      +10     
  Misses        127      127
Impacted Files Coverage Δ
lib/rules/DuplicateImport.js 87.50% <ø> (ø)
lib/rules/UnusedImport.js 80.00% <ø> (ø)
lib/codenarc-factory.js 96.60% <100.00%> (ø)
lib/groovy-lint-fix.js 98.57% <100.00%> (+0.01%) ⬆️
lib/groovy-lint.js 99.54% <100.00%> (+<0.01%) ⬆️
lib/rules/BlankLineBeforePackage.js 88.88% <100.00%> (+3.17%) ⬆️
lib/rules/FileEndsWithoutNewline.js 100.00% <100.00%> (ø)
lib/test/helpers/common.js 90.90% <100.00%> (ø)
lib/utils.js 94.82% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8b987...0ab97ed. Read the comment docs.

@nvuillam nvuillam merged commit e5b99b8 into master Jul 9, 2020
@nvuillam nvuillam deleted the FixEOL branch July 9, 2020 10:24
@nvuillam nvuillam mentioned this pull request Jul 11, 2020
Closed
nvuillam added a commit to nvuillam/vscode-groovy-lint that referenced this pull request Jul 12, 2020
@nvuillam
Override java VM & EOL fix
9cbc519 
- New settings **groovyLint.java.executable** and **groovyLint.java.options**
- Upgrade to [npm-groovy-lint](https://www.npmjs.com/package/npm-groovy-lint) v5.5.0
  - Allow to override java executable and options [(#54)](#54)
  - Use os.EOL [(#65)](nvuillam/npm-groovy-lint#65) solving  [(#63)](nvuillam/npm-groovy-lint#63) --fix for indentation adds CRLF line-endings to all files it touches
@nvuillam nvuillam mentioned this pull request Jul 12, 2020
Merged
nvuillam added a commit to nvuillam/vscode-groovy-lint that referenced this pull request Jul 12, 2020
@nvuillam
Override java VM & EOL fix (#63)
596d57f 
- New settings **groovyLint.java.executable** and **groovyLint.java.options**
- Upgrade to [npm-groovy-lint](https://www.npmjs.com/package/npm-groovy-lint) v5.5.0
  - Allow to override java executable and options [(#54)](#54)
  - Use os.EOL [(#65)](nvuillam/npm-groovy-lint#65) solving  [(#63)](nvuillam/npm-groovy-lint#63) --fix for indentation adds CRLF line-endings to all files it touches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--fix for indentation adds CRLF line-endings to all files it touches
2 participants
@nvuillam @codecov-commenter