Allow bench_refs() and bench_local_refs() to capture input lifetimes #54
+61
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvzqz
reviewed
May 25, 2024
Prepare tests that currently fail to compile, showing that bench outputs can't capture the input lifetime.
…etimes By naming the input lifetime, the output type `O` is allowed to capture this lifetime. The `I: 'i` condition for `&'i mut I` must be made explicit now with named `'i`, or the code won't compile. This makes all Capturing tests added in the previous commit compile.
|
Any suggestions for a good example? In my project I'm using it for benchmarking a parser that creates a token stream/tree which references the input, but that seems too complex for an example (and it uses a separate parser crate). I guess I could do something simple like collecting the result of |
Add a simple example that shows that bench_refs/bench_local_refs input lifetimes may be captured now.
|
I have updated the PR with the suggested changes. I'm not really happy with the example, but I've added a comment to explain what it is supposed to demonstrate. |
|
Any further comments? |
|
@nvzqz Is there anything else you'd like me to change in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows benchmarks using bench_refs() and bench_local_refs() to capture the input lifetimes, as was already suggested by TODO comments in the code.
By naming the input lifetime, the output type
Ois allowed to capture this lifetime. TheI: 'icondition for&'i mut Imust be made explicit now with named'i, or the code won't compile.First commit adds tests that don't compile, second commit makes them compile.