meson.build: don't regenerate readme at build time #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, this part is done by script. The only manual part is the one where you copy the file from build dir to source root. Nevertheless, I agree it can be a problem, but I think it's worth having. How about we hide it behind a disabled-by-default meson option? |
Siborgium
added a commit
that referenced
this pull request
Nov 25, 2022
Siborgium
added a commit
that referenced
this pull request
Nov 25, 2022
I would say this is still probably wrong. Why not instead make it a |
|
It's actually a good idea, although I'd prefer to make it a named target. |
Siborgium
added a commit
that referenced
this pull request
Dec 3, 2022
Siborgium
added a commit
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup involves manually extracting the help output of the built programs at build time to keep the README up to date. I discovered this is a bit fragile and breaks on crossbuilds, and would recommend having this as a CI target instead