Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 MAS-ready on launch? #4556

Closed
haraldox opened this issue Mar 12, 2016 · 66 comments
Closed

0.13 MAS-ready on launch? #4556

haraldox opened this issue Mar 12, 2016 · 66 comments
Milestone

Comments

@haraldox
Copy link

Hi there!

Huge thanks to @rogerwang & team & collaborators (& Intel for sponsoring) for their efforts on nw.js 0.13!! => Looking so much forward to Launch Day :)

We are currently developing in parallel for Electron and nw.js (as cross-compatible Chrome App) and need to know how this will play out with Apple's Mac App Store requirements and review process in the near future! to make a decision about which "container" to use for our release...

We are currently only aware of Audio & Video Playback licensing issues resulting in Apple not allowing such apps in Mac App Store (ffmpeg). See this issue for details.

On a technical sidenote: According to @johansatge's nwjs-macappstore-builder and this comment , is ready for 0.13

Does anyone have any recent experiences with this?

@rogerwang
Copy link
Member

CC @alexeyst who worked on this. Would you mind to check whether the current RC version MAS compatible? Thanks.

@haraldox
Copy link
Author

@rogerwang @alexeyst any new developments on this? all related issues are from 2015 and apply only to 0.12

@rogerwang
Copy link
Member

Since @alexeyst is not responding, I reassign this issue to @ghostoy

@rogerwang rogerwang added this to the 0.13.x milestone Apr 14, 2016
@ghostoy
Copy link
Member

ghostoy commented Apr 20, 2016

Sub-tasks for MAS support:

  • Sandbox
    • deny network-bind
    • deny mach global lookup
    • socket path too long
  • Code signing
    • Remove unused bundles (app_mode_loader)
    • Update CFBundleIdentifier for all bundles
    • Minimal entitlements
    • Signing process and scripts
  • Other uploading issues

@haraldox
Copy link
Author

@ghostoy Wow, great work and super-fast too!! :))) can't wait to check out the MAS build flavor 👍 💯

@ghostoy
Copy link
Member

ghostoy commented May 9, 2016

@haraldox Here is the test build for MAS flavor you can try with http://dl.nwjs.io/live-build/05-09-2016/nw14-df7f7cf-723666b-756e507-5a26102. There is also a reference script for signing the app in https://github.com/ghostoy/nw.js/tree/nw14-mas/tools/mas. Would you please try wit this version and give us feedback? :)

@jpittner
Copy link

I'm getting this message when verifying the signing with spctl -a -vvvv "$app"
dist/nwjs.app: a sealed resource is missing or invalid

This is after copying my app to app.nw and then running the signing script.

@ghostoy
Copy link
Member

ghostoy commented May 12, 2016

@jpittner I can't reproduce the error with spctl tool. Does it fail if you sign the app without app.nw?

@jpittner
Copy link

@ghostoy if I just copy the nwjs.app from the zip file, throw that into src/ and don't change the Info.plist, and don't add the app.nw, spctl fails with error rejected (with no details provided. apparently Apple doesn't understand what verbose means)

I then take the Info.plist from nwjs.app and change the bundle identifier to com.me.myapp, CFBundleDisplayName to myapp. I copy the app.nw to the proper directory and then sign. This results in the error "a sealed resource is missing or invalid".

@ghostoy
Copy link
Member

ghostoy commented May 24, 2016

@jpittner The signing script will properly change all the bundle identifiers and versions with the given parameters for your app. Or you have to change all the plist files nested in the app, including the framework and helper.

As for the "rejected" status, since your app is not on Mac App Store yet, your certificate will be rejected by spctl. But it doesn't matter for submission. If you want to distribute your app out of Mac Store, you you have to sign it with "Developer ID XXX Certificates" instead of "3rd Party XXX Certificates" and spctl tool will be happy with it.

@ghostoy
Copy link
Member

ghostoy commented May 24, 2016

@jpittner @haraldox So far, my testing app can be successfully upload to the store. But I'm not able to test for publishing the app. If you see any other problems submitting to Mac Store, please let me know.

@ghostoy
Copy link
Member

ghostoy commented Jun 8, 2016

@jpittner @haraldox @gpetrov We have announced the alpha testing for MAS build of 0.14.4 in the mailing list recently. If you have any problem using MAS build for NW.js 0.14.4, please send your further feedback here.

Once it's confirmed that Apple accepts the NW.js based app, we will finish alpha testing and release beta versions of MAS builds for LTS (0.14.x) and stable versions.

@gpetrov
Copy link

gpetrov commented Jun 8, 2016

@ghostoy We would really like to try the MAS right now, but our app requires File/Folder permissions outside the App Container. So we need to ask the user for permissions according to Apple guidelines.
This is done through the open file open dialogs api. IS there support or API for this in NW.js?

See https://developer.apple.com/library/mac/documentation/Security/Conceptual/AppSandboxDesignGuide/AppSandboxInDepth/AppSandboxInDepth.html#//apple_ref/doc/uid/TP40011183-CH3-SW8

@ghostoy
Copy link
Member

ghostoy commented Jun 8, 2016

Yes, it's automatically done through <input type="file">.

@gpetrov
Copy link

gpetrov commented Jun 8, 2016

@ghostoy that's awesome! Does it work for folder picking as well? And are the authorizations saved even if the app restarts afterwards? So that it has a lifetime authorization?

@ghostoy
Copy link
Member

ghostoy commented Jun 13, 2016

@gpetrov Yes, it works for folder picking. NW.js uses the standard NSOpenPanel & NSSavePanel.
For how long the authorization can keep, it's controlled by OS X. According to Apple's doc, it's not persist accross launches and restarts. If you want so, you have to ask user to open the file next time or use so called bookmarks (not yet supported). I saw there was an discussion in #1755 about the security scoped bookmarks. If the issue blocks you, please open an issue for it.

@ghostoy
Copy link
Member

ghostoy commented Jul 8, 2016

@gpetrov @jpittner Do you have further feedbacks on the MAS build? Does it pass the Apple's reviews for publication?

@anku94
Copy link

anku94 commented Jul 11, 2016

Is there an approximate timeline for this feature? We have an app ported from MacGap to nwjs waiting for a stable MAS version.

@ghostoy
Copy link
Member

ghostoy commented Jul 11, 2016

The MAS build here can be successfully uploaded. But we are unable to
publish app to store. So we need at least one confirmation from testers
that Apple can accept the submitted app to finish the alpha testing. Would
you like to test it?

anku94 notifications@github.com于2016年7月11日周一 18:45写道:

Is there an approximate timeline for this feature? We have an app ported
from MacGap to nwjs waiting for a stable MAS version.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4556 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAczeDIPuM8TfGaChniHwNHsFoMtvVwIks5qUh7RgaJpZM4HvRnm
.

@ghostoy
Copy link
Member

ghostoy commented Jul 14, 2016

@anku94 Could you help to test if alpha build can be published to App Store?

@anku94
Copy link

anku94 commented Jul 15, 2016

Hey, sorry for the delayed reply. Will try it over the weekend and let you
guys know.

@ghostoy
Copy link
Member

ghostoy commented Jul 21, 2016

@anku94 Did you get approval from App Store?

@ghostoy
Copy link
Member

ghostoy commented Dec 19, 2016

@gpetrov Sure.

@ggarek
Copy link

ggarek commented Dec 26, 2016

@ghostoy i wonder what is the progress on including MAS builds in published builds and live builds?

As i understand, there is only one MAS build published for now.

Thank you and all participants for the great job! 👍

@ghostoy
Copy link
Member

ghostoy commented Jan 16, 2017

Beta release based on 0.19.5 is available in http://dl.nwjs.io/v0.19.5-mas-beta/. Please follow the document of Support for Mac App Store for the signing process and usage of the signing scripts.

@ggarek
Copy link

ggarek commented Jan 25, 2017

My app passed review successfully, thus confirming that v0.19.5 mas build and signing script works fine. Thank you @ghostoy and nwjs team.

my app "Facy" on AppStore

@ripexz
Copy link

ripexz commented Feb 1, 2017

Look forward to seeing it with published builds, will be easier to automate the whole process with nw-builder.

@ripexz
Copy link

ripexz commented Jun 8, 2017

@chino23 @rogerwang Any update on 0.20.x builds?

@rogerwang
Copy link
Member

CC @sunlin-link who own this branch now.

@DrDoing
Copy link

DrDoing commented Oct 24, 2017

@rogerwang will there be a 0.26.x Build for MAS ?
Last succesfull submission of my app was with 0.19.5, since them there are no new MAS Build's

@rogerwang
Copy link
Member

@DrDoing good to know the old version is working for you. @sunlin-link has been working on a new version of MAS build. He will report here if there is any progress.

@DrDoing
Copy link

DrDoing commented Jan 23, 2018

any news about a new MAS build ?
or ist it now possible to use a normal MAC Build for Mac appstore ?

@rogerwang
Copy link
Member

@sunlin-link please advise. Last time I heard from you it's said to be "nearly done".

@sunlin-link
Copy link

I've already finished rebasing to lastest stable release and am working on a final crash issue.
I'll give a commit this week and hope to resolve this issue soon.

@conceptualspace
Copy link

ping

@gpetrov
Copy link

gpetrov commented Jun 5, 2018

@sunlin-link how is the progress with the latest NWJS build as MAS? We really need it to publish our app to the Mac Store.

@ncnlinh
Copy link

ncnlinh commented Jun 11, 2018

@gpetrov same situation here. My app is published on macupdate and our webpage, but it would be great if we can put it on the official app store!

@sadikyalcin
Copy link

sadikyalcin commented Jun 29, 2018

Is this still being maintained or not? I have so many issues with a regular nwjs build since the mas version is just too old to use: https://groups.google.com/forum/#!topic/nwjs-general/EE8eYlG3XgE

@ncnlinh
Copy link

ncnlinh commented Jul 25, 2018

@sadikyalcin NW.js is being actively maintained. But I don't think the Mac App Store version is, which is a shame.

@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests