Unable to build NW.js distribution (missing natives_blob.bin)

[llamasoft]

NWJS Version: nw44
Operating System: Ubuntu

I've been working on building NW.js for ARM and it's been going well except for the final step. I've been using the buildbot commands as reference. The issue is that the dist build target fails with the following:

ninja: Entering directory `out/nw'
[1/2] ACTION //content/nw:dist(//build/toolchain/linux:clang_arm)
FAILED: new_package.re
python ../../content/nw/tools/package_binaries.py -p /root/nwjs/src/out/nw -a arm -m sdk -i /root/nwjs/src/third_party/icu/common/icudtl.dat
Begin copy file
copy file end
Begin compress file
compress end
Working on /root/nwjs/src/out/nw
../../content/nw/tools/make-nw-headers.py
nw-headers generated
Creating packages...
File does not exist:  /root/nwjs/src/out/nw/natives_blob.bin
ninja: build stopped: subcommand failed.

As best I can tell, it's not actually possible to build natives_blob.bin, so I'm wondering how the buildbot manages to succeed here.

The file is created by third_party/node-nw/deps/v8/BUILD.gn, but node is built using GYP, not GN, so the file is never directly included. (It appears to have portions indirectly included using third_party/node-nw/tools/v8_gypfiles/v8.gyp.)

Even if node were built with GN, it only appears to be possible to build a blank natives_blob.bin file:

• The natives_blob action depends on the js2c_extras action.
• The js2c_extras action passes its sources (v8_extra_library_files) to tools/js2c.py.
• The v8_extra_library_files variable is asserted to be empty.

I ran the actions' python scripts directly and the result was a 1-byte natives_blob.bin file, but somehow the builtbot releases contain an actual file?

[rogerwang]

Hello, that file is not needed anymore. Will submit a fix to remove it. Thanks.

[llamasoft]

I've submitted a PR to remove the natives_blob.bin file from the packaging script. I've also added a small tweak to the nacl_irt file naming so that it supports ARM builds as part of issue #1151.