Optionally override docker FROM image with build-args #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make building docker images from other branches, like preview, a little easier. Example usage: - docker build . -t nwnxee/unified:build8193.37.2 --build-arg BUILDER_IMAGE="ghcr.io/nwnxee/builder:2186dc2" --build-arg BASE_IMAGE="ghcr.io/urothis/nwserver:8193.37.2"
|
It took me a while to realize this was the easiest way to build an image of the preview build for debugging. It's a little hidden so I can write a note about it in the README or somewhere else if you think it should be documented better. |
|
Wait, now that I read closer I see the resulting image will not necessarily have the run-deps installed that are defined in Edit: amended by introducing |
jakkn
force-pushed
the
optionally-override-docker-from-image-with-build-args
branch
from
9d4cabb to
f55d01a
Compare
Building the final image takes a bit of care getting all the arguments right. This script makes building images a little more convenient by using the version defined by cmake for the given branch, just like the CI workflows do.
jakkn
force-pushed
the
optionally-override-docker-from-image-with-build-args
branch
from
f55d01a to
a4869fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make building docker images from other branches, like preview, a little easier.
Example usage:
Defaults are left untouched so this change should not break anything.
Edit 29.03.24:
Scripts/buildimages.shhas been added to make building images easier. Example output (before it runs the docker build commands):Example of the resulting images running the script on branches
masterandbuild8193.37