Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoStack: Ignore Supernatural Innate Effects (Feat, Race, SkillRanks) #1778

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

plenarius
Copy link
Collaborator

This offers the builder the option to set NWNX_NOSTACK_IGNORE_SUPERNATURAL_INNATE to true so your NoStack rules are ignored for effects granted through the Feat, Race and SkillRanks plugins.

These plugins set the subtype to Constants::EffectSubType::Supernatural | Constants::EffectDurationType::Innate on the effects granted.

This also corrects an issue when NoStack GetTotalEffectBonus hook was not increasing max caps for ability bonuses granted via the other plugins.

@plenarius plenarius self-assigned this Sep 22, 2024
@plenarius
Copy link
Collaborator Author

I don't know if there are any other Supernatural Innate effects in game that you'd want to honour your NoStack rules with but not these. I doubt it?

@plenarius plenarius merged commit 02bc1b1 into nwnxee:master Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant