Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler: fixed order of parameters in nss script for PushPerfScope() #1799

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

julien-lecomte
Copy link
Contributor

Without this patch, the result of NWNX_Profiler_PushPerfScope("PerfScopeName", "tag0_tag", "tag0_value"); is NWNX_Profiler.TimingEvent,EventName=tag0_tag,tag0_value=PerfScopeName

The patch fixes the order of the pushed arguments:

NWNX_Profiler_PushPerfScope("Test2", "tag0_tag", "tag0_value");
NWNX_Profiler_PushPerfScope("Test3", "tag0_tag", "tag0_value");

# Gives:
NWNX_Profiler.TimingEvent,EventName=Test2,tag0_tag=tag0_value
NWNX_Profiler.TimingEvent,EventName=Test3

@Daztek Daztek merged commit 09544eb into nwnxee:master Dec 20, 2024
5 checks passed
@julien-lecomte julien-lecomte deleted the fix-profiler-nss branch December 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants