Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with page speed insights #84

Open
kaihendry opened this issue Apr 6, 2020 · 8 comments
Open

Use with page speed insights #84

kaihendry opened this issue Apr 6, 2020 · 8 comments
Labels
question Further information is requested

Comments

@kaihendry
Copy link

Could you please illustrate how you would use https://github.com/nwtgck/actions-netlify#outputs with https://github.com/marketplace/actions/page-speed-insights ?

Thank you!

@nwtgck
Copy link
Owner

nwtgck commented Apr 6, 2020

@kaihendry Hi,

Here is the yaml.

...
      - name: Running Page Speed Insights
        uses: jakepartusch/psi-action@v1
        with:
          url: ${{ steps.deploy-to-netlify.outputs.deploy-url }}
          threshold: 70
          strategy: mobile

full: https://github.com/nwtgck/actions-netlify/blob/85450f952f626b64861a3facdb5d19519fea07f8/.github/workflows/test.yml

Here is the actual changes: 85450f9 #85

Result

image

Actions: https://github.com/nwtgck/actions-netlify/pull/85/checks?check_run_id=564141914

@kaihendry
Copy link
Author

kaihendry added a commit to kaihendry/dabase.com that referenced this issue Apr 7, 2020
@kaihendry
Copy link
Author

Would prefer to see Pagespeed output on the PR itself...

image

@nwtgck
Copy link
Owner

nwtgck commented Apr 7, 2020

I'm not sure why the error caused. But it says " ##[error]Url is required to run Page Speed Insights."

image

@nwtgck
Copy link
Owner

nwtgck commented Apr 7, 2020

Have you tried the following setting? Because the error might not cause by actions-netlify.

...
        with:
          url: "https://dabase.com/"
          threshold: 70
          strategy: mobile

@nwtgck
Copy link
Owner

nwtgck commented Apr 14, 2020

@kaihendry Have you tried this?

@AllanOricil
Copy link

I think it had an error because it was a draft. To run it you would need the draft to be published.

@nwtgck
Copy link
Owner

nwtgck commented May 29, 2020

@kaihendry ping?? I'd like to close the issue when you solved this.

@nwtgck nwtgck added the question Further information is requested label Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants