Broken on Mac because of \r instead of \n

[adius]

You're using the carriage return character (used on windows) and not the newline character for line breaks. => It's broken on mac and linux.

$ nwbuild -r ./app

env: node\r: No such file or directory

[konsumer]

+1

[felicienfrancois]

Seems to be a reccuring issue: #75, #108, #109

You can fix it by removing all \r in node-webkit-builder files. You can do it with most code editors, including vim with the following command :set ff=unix.

If you've time to, you can make a pull request.

[felicienfrancois]

Also note that windows uses \r\n and not \r alone. So \r should be removed and not replaced.

\r alone was used by old Mac OS (before it comes to a FreeBSD fork)

[konsumer]

I tried to make a PR, but it didn't register just \n changes. WIll need to investigate when I have a minute.

[adam-lynch]

Would love a PR to fix this. Maybe a build step to normalize line-endings would be the best solution. Maybe https://github.com/ryanve/eol would help, I don't know.

[konsumer]

This would fix it once, as just doing it in your editor, but it still won't register in git. see this for a fix. I will try to make a PR for it, now.

[konsumer]

actually, it looks like you already have that. hmm.

[konsumer]

And ./bin/nwbuild works, so maybe just npm publish?

[adam-lynch]

@konsumer 99.9999% sure I did that ("Dealing with line endings") before to fix this and it did nothing.

---

And ./bin/nwbuild works, so maybe just npm publish?

I'm not following you.

[konsumer]

Yep, that is my comment above. Just made build script to fix line-endings & publish to npm. I think maybe npm doesn't fix line-endings like git does.

[konsumer]

What I am saying is that my actual checkout is fine (I can run ./bin/nwbuild, which is what your package.json links to in bin) so it's something other than .gitattributes file, which you already made. To fix this, regardless of whether it's an issue with how npm packages files, I made a nice build script for you :) It also bumps the patch semver & pushes to npm, so you have a nice stable way to send files up to npm that you can be sure has the correct line-endings.

[adam-lynch]

Fixed in 1.0.9.