Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated package.json #11

Merged
merged 2 commits into from
Feb 22, 2015
Merged

updated package.json #11

merged 2 commits into from
Feb 22, 2015

Conversation

skibz
Copy link
Contributor

@skibz skibz commented Feb 19, 2015

  • fixed version number (npm refuses to work on my computer without a semver type version number)
  • added the usual suspects for dev deps (assertion libraries, test runner, etc)
  • made the packagejson private, cause, yknow :P
  • this just needs my gitignore additions now...
  • added scripts block (more to appear here)
  • added contributors list

fixed version number (npm refuses to work on my computer without a semver type version number)
added the usual suspects for dev deps
this just needs my gitignore additions now...
@skibz skibz mentioned this pull request Feb 19, 2015
CyrisXD added a commit that referenced this pull request Feb 22, 2015
@CyrisXD CyrisXD merged commit 39c6732 into CyrisXD:master Feb 22, 2015
@skibz
Copy link
Contributor Author

skibz commented Feb 23, 2015

@CyrisXD
#15

i, too, am hesitant about adding gulp. this project only needs a few command line programs for package maintenance. a build task that would help with generating releases, a dev task to build and run the project locally and finally a test task to run a test suite. not much more is needed, by the looks of things.

@odensc
Copy link
Contributor

odensc commented Feb 23, 2015

@CyrisXD @skibz
What else would you suggest? Make scripts like build.js, test.js, etc. and add them to the package.json scripts?

@skibz
Copy link
Contributor Author

skibz commented Feb 23, 2015

@TheSBros if we used gulp, it would allow us to add the gulp-node-webkit-builder tool which frees us of worrying about the state of node-webkit-builder (it's pretty unhealthy right now - broken for os x)

but i do, personally, prefer just using npm scripts.

@odensc
Copy link
Contributor

odensc commented Feb 23, 2015

@skibz node-webkit-builder worked fine for me on OS X last night.

@skibz
Copy link
Contributor Author

skibz commented Feb 23, 2015

@TheSBros i can't build for os x due to this: nwutils/nw-builder#188

@odensc
Copy link
Contributor

odensc commented Feb 23, 2015

@skibz Does that only affect CLI? I was using the API.

@skibz
Copy link
Contributor Author

skibz commented Feb 23, 2015

@TheSBros it does seem to only affect command line.
i was using nwbuild -r . to build and run while developing.

wanted to make a npm script a la: ./node_modules/.bin/nwbuild -r .

@CyrisXD
Copy link
Owner

CyrisXD commented Feb 23, 2015

@skibz @TheSBros you guys are obviously far more experienced with the tools and automation process than I am. To test my builds I've just been dragging the source folder over nw.exe, then to build I just use the command line.

Windows: Making an executable file out of a .nw file.
copy /b nw.exe+app.nw app.exe

Linux: Making an executable file out of a .nw file.
cat /usr/bin/nw app.nw > app && chmod +x app

Max OSX: Making an executable file out of a .nw file.
https://github.com/rogerwang/node-webkit/wiki/How-to-package-and-distribute-your-apps#mac-os-x

I'm still fairly new to Node-webkit and have been learning as I was building. Found this very useful.

@skibz
Copy link
Contributor Author

skibz commented Feb 24, 2015

@CyrisXD there isn't anything wrong with your testing process. and those are, indeed, good resources for learning.

@TheSBros the issue i linked yesterday has been resolved. so node-webkit-builder now properly works on os x again! 🎉

now we just have to decide on gulp or plain npm.

@odensc
Copy link
Contributor

odensc commented Feb 24, 2015

@skibz I mentioned Build System on #22 so you can put any opinions you have there if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants