feat(run): return NW.js process reference #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ayushmanchhabra
commented
Nov 20, 2024
•
ayushmanchhabra
commented
- This allows us to kill the process via code which is useful during testing.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Tests for renaming MacOS Helper apps seem to be flaky. Will address in seperate PR. |
ayushmanchhabra
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- ## [4.12.0](v4.11.6...v4.12.0) (2024-11-21) ### Features * **run:** return NW.js process reference ([#1304](#1304)) ([bd2f926](bd2f926)) ### Bug Fixes * miscellaneous quality of life improvements ([#1296](#1296)) ([a82c140](a82c140)) * **util:** validate options.* correctly ([#1298](#1298)) ([3034f5c](3034f5c)) * **util:** validate options.app.* values ([#1302](#1302)) ([4f388a9](4f388a9)), closes [#1279](#1279) [#1293](#1293) ### Chores * **deps-dev:** bump the npm group across 1 directory with 6 updates ([#1301](#1301)) ([56c1192](56c1192)) * **deps:** bump cross-spawn from 7.0.3 to 7.0.6 ([#1305](#1305)) ([2803af3](2803af3)) * **deps:** bump davelosert/vitest-coverage-report-action from 2.6.0 to 2.7.0 in /.github/workflows in the gha group ([#1295](#1295)) ([23aaad8](23aaad8)) * **deps:** bump davelosert/vitest-coverage-report-action from 2.7.0 to 2.8.0 in /.github/workflows in the gha group ([#1303](#1303)) ([ceaf348](ceaf348)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.