chore(next): add routing #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmanchhabra
commented
Jan 25, 2024
| <li>Chromium: {nw.require('process').version['chromium']}</li> | ||
| <li>Node.js: {nw.require('process').version['node']}</li> | ||
| <li>V8: {nw.require('process').version['v8']}</li> | ||
| <li>NW.js: {nw && nw.require('node:process').versions['nw']}</li> |
There was a problem hiding this comment.
During development, this works fine. But after building web app, the code after nw && is stripped out by the compiler. Ideally, we don't want this to happen. Maybe the way is to not bundle and minify web apps and run them as is?
|
Will have to research and figure out how to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
./hooksworkaroundnw.requireduring dev modenw.requireafter building appFixes: #1