Support cryptography >= 37.0.0 #43
Conversation
spsdk/crypto/__init__.py: The unused wildcard import of `cryptography.hazmat.backends.interfaces` prevents spsdk to work with cryptography >= 37.0.0. None of the Backend classes found in the module are used and therefore the import can be safely removed.
requirements.txt: When removing unused imports, spsdk is actually compatible with cryptography >= 37.0.0.
|
Related: I think it would be best to completely circumvent wildcard imports such as the one I removed: If there are issues with mypy, then it either needs to be configured differently or typing issues need to be ignored. |
|
@mwsk It would be really helpful to get feedback on these types of PRs, as they are vital for downstreams. |
|
Hello @dvzrv, thanks for your PR. I have tested cryptography 37 and 38 and it seems that everything is working as expected. The only downside is quite a significant slowdown when operating with RSA keys. See pyca/cryptography#7236 The next version of SPSDK will support cryptography 38+. |
Fixes #42