stream: fix multiple Writable.destroy() calls.

Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189
nxtedition · Apr 12, 2021 · 6ae4e4a · 6ae4e4a
1 parent 30fe4ed
commit 6ae4e4a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -855,10 +855,10 @@ Writable.prototype.destroy = function(err, cb) {
 
   // Invoke pending callbacks.
   if (
+    !state.destroyed && (
     state.bufferedIndex < state.buffered.length ||
     state[kOnFinished].length
-  ) {
-    assert(!state.destroyed);
+  )) {
     process.nextTick(errorBuffer, state);
   }
 

diff --git a/test/parallel/test-stream-writable-destroy.js b/test/parallel/test-stream-writable-destroy.js
@@ -460,3 +460,14 @@ const assert = require('assert');
     assert.strictEqual(write.destroyed, true);
   }));
 }
+
+{
+  // Destroy twice
+  const write = new Writable({
+    write(chunk, enc, cb) { cb(); }
+  });
+
+  write.end(common.mustCall());
+  write.destroy();
+  write.destroy();
+}