-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ionic-react): generate applications with ionic v6 #606
base: main
Are you sure you want to change the base?
Conversation
Hello @eduardoRoth, from my understanding, @devinshoemaker was facing Jest issues causing a delay in cutting release for Nx13 support, hence he went ahead with skipping Ionic 6 for now and released Nx13 support without it. This PR does not touch those needed Jest setups., any chance that you have a possible fix on that part? |
Hi @samratarmas For For The only issue that I'm having is a warning about I'll take a look at it, but aside from that, everything is working as expected. |
Did I understand correctly that nxtend does not support Ionic v6? If it is not supported, when do you plan to do so and will this then effect angualr, react and vue? Thank you guys. |
@SerkanSipahi nxtend currently supports Ionic v6, but you need to manually update it. What this PR does, is that nxtend generates the app in v6 as default, instead of v5 |
@eduardoRoth I didn't really understand why this is not supported by the standard. |
Hey, thanks for the PR. I finally have some time to look into this again, but I'm still having issues with e2e tests. More specifically, the unit tests that are run within the e2e tests fail due to a Jest issue with the Ionic dependencies. If that's something you can get working locally then I'd love to merge your PR. |
Description
Update Ionic to v6
PR Checklist