Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ionic-react): generate applications with ionic v6 #606

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eduardoRoth
Copy link
Contributor

Description

Update Ionic to v6

PR Checklist

  • Migrations have been added if necessary
  • Unit tests have been added or updated if necessary
  • e2e tests have been added or updated if necessary
  • Changelog has been updated if necessary
  • Documentation has been updated if necessary

@samratarmas
Copy link

Hello @eduardoRoth, from my understanding, @devinshoemaker was facing Jest issues causing a delay in cutting release for Nx13 support, hence he went ahead with skipping Ionic 6 for now and released Nx13 support without it. This PR does not touch those needed Jest setups., any chance that you have a possible fix on that part?

@eduardoRoth
Copy link
Contributor Author

eduardoRoth commented Feb 16, 2022

Hi @samratarmas

For ionic-angular all the test successfully passed
image

For ionic-react I forgot to remove one expect as it's no longer needed, but after doing that, everything passes:
image

The only issue that I'm having is a warning about .gitignore:

image

I'll take a look at it, but aside from that, everything is working as expected.

@SerkanSipahi
Copy link

SerkanSipahi commented Feb 17, 2022

Did I understand correctly that nxtend does not support Ionic v6? If it is not supported, when do you plan to do so and will this then effect angualr, react and vue? Thank you guys.

@eduardoRoth
Copy link
Contributor Author

Did I understand correctly that nxtend does not support Ionic v6? If it is not supported, when do you plan to do so and will this then effect angualr, react and vue? Thank you guys.

@SerkanSipahi nxtend currently supports Ionic v6, but you need to manually update it. What this PR does, is that nxtend generates the app in v6 as default, instead of v5

@SerkanSipahi
Copy link

@eduardoRoth I didn't really understand why this is not supported by the standard.

@devinshoemaker
Copy link
Collaborator

Hey, thanks for the PR. I finally have some time to look into this again, but I'm still having issues with e2e tests. More specifically, the unit tests that are run within the e2e tests fail due to a Jest issue with the Ionic dependencies. If that's something you can get working locally then I'd love to merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants