Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

fix(capacitor): project config param changes fix #631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(capacitor): project config param changes fix #631

wants to merge 1 commit into from

Conversation

nikita-yaroshevich
Copy link

Hotfix for #630

Description

PR Checklist

  • Migrations have been added if necessary
  • Unit tests have been added or updated if necessary
  • e2e tests have been added or updated if necessary
  • Changelog has been updated if necessary
  • Documentation has been updated if necessary

Issue

#630
Resolves #

@andreiLita
Copy link

@devinshoemaker can someone review this pull request ? This solves the capacitor nx plugin generator.

On another note, this repository is not up to date with the rest of nx. So migrating to the version 14 is required. For example the ionic-react application generator depends on node_modules/nx/src/utils/app-root. This file does not exist anymore in the current version of nx@14.2.4.

@rhutchison
Copy link

I am not sure if these changes are required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhutchison rhutchison rhutchison approved these changes

@luisfelipediaz luisfelipediaz luisfelipediaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikita-yaroshevich @andreiLita @rhutchison @luisfelipediaz