Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework clogs util package based on latest gocommon #330

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

rowanseymour
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (1c8cccd) to head (4f74883).

Files with missing lines Patch % Lines
utils/clogs/clog.go 76.92% 3 Missing and 3 partials ⚠️
utils/clogs/batch.go 71.42% 2 Missing and 2 partials ⚠️
core/models/channel_logs.go 0.00% 0 Missing and 1 partial ⚠️
mailroom.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   63.20%   63.23%   +0.02%     
==========================================
  Files         191      191              
  Lines       10650    10631      -19     
==========================================
- Hits         6731     6722       -9     
+ Misses       3033     3024       -9     
+ Partials      886      885       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit b90d7f1 into main Sep 16, 2024
5 checks passed
@rowanseymour rowanseymour deleted the clogs4 branch September 16, 2024 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants