Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework session_triggered event handling to make it easier to switch to non-persistent starts #334

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (6e84279) to head (18c836a).

Files with missing lines Patch % Lines
core/hooks/create_starts.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   63.28%   63.23%   -0.05%     
==========================================
  Files         190      189       -1     
  Lines       10584    10563      -21     
==========================================
- Hits         6698     6680      -18     
+ Misses       2999     2997       -2     
+ Partials      887      886       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 2038472 into main Sep 19, 2024
5 checks passed
@rowanseymour rowanseymour deleted the rework_starts_hook branch September 19, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants