Add user settings fields for email verification #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4938 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 548 548
Lines 25929 26144 +215
==========================================
+ Hits 25929 26144 +215
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
temba/orgs/models.py
Outdated
| @@ -341,6 +341,8 @@ class UserSettings(models.Model): | |||
| last_auth_on = models.DateTimeField(null=True) | |||
| external_id = models.CharField(max_length=128, null=True) | |||
| verification_token = models.CharField(max_length=64, null=True) | |||
| email_verified = models.BooleanField(default=False) | |||
There was a problem hiding this comment.
maybe it would be useful to have different states here like UNVERIFIED, VERIFIED, FAILING ?
norkans7
force-pushed
the
email-verification
branch
2 times, most recently
from
a3623dd to
2040955
Compare
| STATUS_FAILING = "F" | ||
| STATUS_CHOICES = ( | ||
| (STATUS_VERIFIED, _("Verified")), | ||
| (STATUS_UNVERIFIED, _("Unverified")), |
There was a problem hiding this comment.
Very minor but feels like STATUS_UNVERIFIED should come first as that's the default state
norkans7
force-pushed
the
email-verification
branch
from
2040955 to
a5184cb
Compare
rowanseymour
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.