Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save authentication FCM config as JSON dumps #5433

Closed
wants to merge 1 commit into from
Closed

Conversation

norkans7
Copy link

@norkans7 norkans7 commented Aug 7, 2024

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (92678a4) to head (b170c6b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5433   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          507       507           
  Lines        25251     25252    +1     
=========================================
+ Hits         25251     25252    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7 norkans7 requested a review from rowanseymour August 7, 2024 10:56
@rowanseymour
Copy link
Member

@norkans7 cn't we fix this on the courier side? marshaled JSON inside of JSON isn't ideal

@norkans7
Copy link
Author

norkans7 commented Aug 7, 2024

replaced by nyaruka/courier#769

@norkans7 norkans7 closed this Aug 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
@norkans7 norkans7 deleted the fix-fcm branch August 7, 2024 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants