Tweak metrics namespace and fix metric names and dimensions #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Dec 16, 2024
| Value: aws.Float64(float64(totalMsgsRecordsArchived)), | ||
| Unit: types.StandardUnitCount, | ||
| }, | ||
| { | ||
| MetricName: aws.String("MsgsArchivedsCreated"), |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 62.93% 62.55% -0.39%
==========================================
Files 7 7
Lines 1376 1362 -14
==========================================
- Hits 866 852 -14
Misses 404 404
Partials 106 106 ☔ View full report in Codecov by Sentry. |
rowanseymour
commented
Dec 16, 2024
| @@ -967,82 +967,68 @@ func ArchiveActiveOrgs(rt *runtime.Runtime) error { | |||
| timeTaken := dates.Now().Sub(start) | |||
| slog.Info("archiving of active orgs complete", "time_taken", timeTaken, "num_orgs", len(orgs)) | |||
|
|
|||
| dims := []types.Dimension{ | |||
| {Name: aws.String("App"), Value: aws.String("archiver")}, | |||
There was a problem hiding this comment.
no reason to have app as a dimension here... there's only one archiver app
norkans7
approved these changes
Dec 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess there's no reason to stuff all our custom metrics into a single namespace - AWS does it per service with namespaces like
AWS/EC2,AWS/ELBetc, so why notTemba/Archiver,Temba/Indexeretc