BUG fixed (#100, #102) #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
July 12, 2015 21:13
…r'. Using hardcode style (TEMP) again/ Hplus-bug (nyergler#100) is gone; but slides2 (gio) and other will not work. Result is not perfect. non-slides sections are gone (instead of div). extra span for IDS are solved to
…d slides are producted. With H3 levels (even with slide_levels=2). This fixes nyergler#100 Have to test for other themes and more complex slides Notice: the slide-directive is not supported with this set-up Some cleanup may be needed
The code works, for slides/slides2/single-level/ themes (so, all) The debug 'hack' statement are removed. Also other touched code is cleaned Notice: a few small default theme setting are improved too: to big slides can scroll now. To big slides are bad. But invisuable lines (small monitor) are even wors as scrolling
Some cleanup is needed Notice: when using autoslides and ..slide, text after a slide become lost -- appearing in the background. There is no doc about how to handle it; but something is needed
…) when using headers above auto-slide-level (bug nyergler#100)
|
There's a lot here, so it's going to take a bit for me to comb through it. Most of my comments from the previous diff stand, I think. Some thoughts skimming through it:
Thanks for opening this; I'll try to review more thoroughly over the weekend. |
|
It also looks like the tests are pretty screwed up. (You can ignore the CircleCI stuff, I've removed it, but the Travis suite should pass.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #100 and #102
Also some docs
Note: The work was done earlier, see the discusion. But due a holiday, i forgot the pull request