Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

adds custom imap and smtp ports when selecting "Other" #129

Merged
merged 1 commit into from
Oct 26, 2017
Merged

adds custom imap and smtp ports when selecting "Other" #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 82 additions & 25 deletions packages/client-app/internal_packages/onboarding/lib/page-account-settings-imap.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,40 +58,97 @@ class AccountIMAPSettingsForm extends React.Component {
}
const {accountInfo, submitting, onFieldKeyPress, onFieldChange} = this.props;

const tempFieldChange = (event) => {
if (event.target.id === "imap_port" || event.target.id === "smtp_port") {
let inputNode = event.target.nextSibling;
if (event.target[event.target.selectedIndex].text === "Other") {
inputNode.style["visibility"] = "inherit";
} else {
inputNode.style["visibility"] = "hidden";
}
}

onFieldChange(event);
};

const customPortInput = (event) => {
if (event.target.id === "imap_port_custom" || event.target.id === "smtp_port_custom") {
let selectNode = event.target.previousSibling;
selectNode[selectNode.length - 1].value = event.target.value; // assumes "Other" is last element
if (selectNode[selectNode.selectedIndex].text === "Other") {
var evt = document.createEvent("HTMLEvents");
evt.initEvent("change", true, true);
selectNode.dispatchEvent(evt);
}
}
};

if (protocol === "imap") {
return (
<span>
<label htmlFor="imap_port">Port:</label>
<select
id="imap_port"
tabIndex={0}
value={accountInfo.imap_port}
disabled={submitting}
onKeyPress={onFieldKeyPress}
onChange={onFieldChange}
>
<option value="143" key="143">143</option>
<option value="993" key="993">993</option>
</select>
<label htmlFor="imap_port_selection">Port:</label>
<div id="imap_port_selection">
<select
id="imap_port"
tabIndex={0}
value={accountInfo.imap_port}
disabled={submitting}
onKeyPress={onFieldKeyPress}
onChange={tempFieldChange}
>
<option value="143" key="143">143</option>
<option value="993" key="993">993</option>
<option id="imap_other" key="Other">Other</option>
</select>
<input id="imap_port_custom" type="number" placeholder="Port" onInput={customPortInput} />
</div>
<style>
{`
#imap_port_selection {
display: inline-block;
}
#imap_port_selection input {
margin-left: 1em;
width: 5.5em;
visibility: hidden;
}
`}
</style>
</span>
)
}
if (protocol === "smtp") {
return (
<span>
<label htmlFor="smtp_port">Port:</label>
<select
id="smtp_port"
tabIndex={0}
value={accountInfo.smtp_port}
disabled={submitting}
onKeyPress={onFieldKeyPress}
onChange={onFieldChange}
>
<option value="25" key="25">25</option>
<option value="465" key="465">465</option>
<option value="587" key="587">587</option>
</select>
<label htmlFor="smtp_port_selection">Port:</label>
<div id="smtp_port_selection">
<select
id="smtp_port"
tabIndex={0}
value={accountInfo.smtp_port}
disabled={submitting}
onKeyPress={onFieldKeyPress}
onChange={tempFieldChange}
>
<option value="25" key="25">25</option>
<option value="465" key="465">465</option>
<option value="587" key="587">587</option>
<option id="smtp_other" key="Other">Other</option>
</select>
<input id="smtp_port_custom" type="number" placeholder="Port" onInput={customPortInput} />
</div>
<style>
{`
#smtp_port_selection {
display: inline-block;
}
#smtp_port_selection input {
margin-left: 1em;
width: 5.5em;
visibility: hidden;
}
`}
</style>
</span>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/client-app/internal_packages/onboarding/stylesheets/onboarding.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@

.page.account-setup.AccountIMAPSettingsForm {
h2 {
padding-top: 36px;
padding-top: 14px;
}
.logo-container {
display: none;
Expand Down