Pasting into a participant field now preserves any text already there (Issue #2410) #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (Issue #2410) This modifies the behavious when pasting into the to, cc or bcc fields of a new draft. Any text already in the input field is not automatically deleted. Rather the pasted text is added to the already existing text. If the new contents of the email field now matches as an email address (based on RegExpUtils.emailRegex().test()), then the address is immediately tokenized. If the new input text doesn't match as an email, just append the new text and wait for further input.
|
Hey! Thanks for contributing this. Long term, we're looking to clean email address specific logic out of TokenizingTextField (and move it to the subclass ParticipantsTextField) but it looks like there's already another reference to the email regex in I believe there's a GitHub issue for this too, will see if I can find it and reference this PR. Cheers— |
|
Marking #2410 as done-pending-release! |
|
|
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the behavious when pasting into the to, cc or bcc fields of a new draft. This allows you to, for example, copy the domain of the email address from the clipboard and type the addressee and then paste the domain. Any text already in the input field is not automatically deleted. Rather the pasted
text is added to the already existing text. If the new contents of the email field now matches as an email address (based on RegExpUtils.emailRegex().test()), then the address is immediately tokenized. If the new input text doesn't match as an email, just append the new text and wait for further input.