Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for count on message/thread search #443

Merged

Conversation

mrashed-dev
Copy link
Contributor

Description

This PR adds count support for SearchCollection type. Closes #416.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d2ab005) 97.86% compared to head (8f0ab80) 97.86%.

Files Patch % Lines
lib/nylas/api.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         128      129    +1     
  Lines        4772     4783   +11     
=======================================
+ Hits         4670     4681   +11     
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrashed-dev mrashed-dev merged commit ab663a1 into main Dec 21, 2023
7 of 8 checks passed
@mrashed-dev mrashed-dev deleted the TW-2445-gh-416-ruby-error-when-calling-messages-search-count branch December 21, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when calling messages.search().count
2 participants