Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support draft filtering #456

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

rfgil
Copy link
Contributor

@rfgil rfgil commented Jan 23, 2024

Description

Support filtering draft messages, using the /drafts endpoint according to the documentation.

As an example, this allows querying for drafts on a given a thread_id using:

nylas_api.drafts.where(thread_id:)

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@mrashed-dev mrashed-dev self-requested a review January 25, 2024 08:23
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (125adcc) 97.97% compared to head (ba48dbb) 97.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         129      129           
  Lines        4797     4798    +1     
=======================================
+ Hits         4700     4701    +1     
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rfgil! 🚀

@mrashed-dev mrashed-dev merged commit 5561ab7 into nylas:main Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants