Add select field to folders find method #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
reviewed
Nov 4, 2024
| @@ -28,9 +28,10 @@ def list(identifier:, query_params: nil) | |||
| # @param identifier [String] Grant ID or email account to query. | |||
| # @param folder_id [String] The id of the folder to return. | |||
AaronDDM
reviewed
Nov 4, 2024
| @@ -42,7 +42,7 @@ | |||
| folder_id = "5d3qmne77v32r8l4phyuksl2x" | |||
| path = "#{api_uri}/v3/grants/#{identifier}/folders/#{folder_id}" | |||
| allow(folders).to receive(:get) | |||
| .with(path: path) | |||
| .with(path: path, query_params: nil) | |||
There was a problem hiding this comment.
Add a new test that tests the query param as well
|
Thanks for this! Just noticed that threads.find is also missing the same. Any chance we could get that while you're at it? |
Sure, thanks for pointing that out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 99.85% 98.83% -1.02%
==========================================
Files 24 29 +5
Lines 681 774 +93
==========================================
+ Hits 680 765 +85
- Misses 1 9 +8 ☔ View full report in Codecov by Sentry. |
AaronDDM
approved these changes
Nov 4, 2024
|
FYI I've tried this out in production and it's working well. Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
selectfield toGET folders/idLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.