Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions and enable fat jar creation #102

Merged
merged 2 commits into from
Feb 20, 2024
Merged

bump versions and enable fat jar creation #102

merged 2 commits into from
Feb 20, 2024

Conversation

nylonee
Copy link
Owner

@nylonee nylonee commented Feb 20, 2024

The last version of watchlistarr failed to build jar versions. This PR is to attempt to fix it

Summary by CodeRabbit

  • Chores
    • Updated logging and YAML parsing libraries to newer versions for improved stability and performance.
  • Refactor
    • Modified the build process to always include a step for creating a comprehensive application package, ensuring consistency across releases.
  • New Features
    • Enhanced the workflow to ensure the "Build fat JAR" step runs consistently regardless of the tag reference.

Copy link

coderabbitai bot commented Feb 20, 2024

Walkthrough

The recent updates involve enhancing the continuous integration process and dependency management for a Java project. The workflow now consistently builds a fat JAR, irrespective of the tag reference, ensuring a more streamlined CI process. Additionally, updates to dependencies improve the project's stability and compatibility, with slf4j and snakeYaml being brought up to more recent versions.

Changes

File(s) Change Summary
.github/workflows/release-java.yml, build.sbt Removed conditional check for "Build fat JAR" step in workflow, updated slf4j from "2.0.9" to "2.0.12", and snakeYaml from "2.0" to "2.2".

🐇✨
In the realm of code where Java beans grow,
A rabbit hopped, making CI flow.
"Update, build, and let dependencies fly,
For stable code under the digital sky.
Let's celebrate, for progress we've made,
With every line and every upgrade."
🎉🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bd0236a and e78d8ce.
Files selected for processing (2)
  • .github/workflows/release-java.yml (1 hunks)
  • build.sbt (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/release-java.yml
Additional comments: 2
build.sbt (2)
  • 21-21: The version of slf4j has been updated to "2.0.12". It's important to verify that this version is compatible with other logging-related dependencies, such as logback-classic, to ensure there are no compatibility issues that could affect logging functionality.
  • 22-22: The version of snakeYaml has been updated to "2.2". Given that snakeYaml is used for YAML parsing, it's crucial to check if there are any breaking changes or new features in this version that might require adjustments in the codebase where YAML parsing is performed.

build.sbt Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e78d8ce and 51dfb48.
Files selected for processing (1)
  • build.sbt (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • build.sbt

@nylonee nylonee merged commit 2da4a80 into main Feb 20, 2024
2 checks passed
@nylonee nylonee deleted the fix-build branch February 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant