Allow debug log flag #95
Conversation
WalkthroughThis update introduces a new configuration option to adjust logging verbosity and clarifies the necessity of a Plex Pass for generating RSS Feed URLs, alongside adjustments in formatting and wording for better clarity. Additionally, it implements a mechanism to enable debug mode through an environment variable, addressing the need for enhanced debugging capabilities. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
src/main/resources/logback.xmlis excluded by:!**/*.xml
Files selected for processing (2)
- README.md (1 hunks)
- docker/entrypoint.sh (1 hunks)
| if [ -n "$LOG_LEVEL" ]; then | ||
| CMD+=("-Dlog.level=$LOG_LEVEL") | ||
| fi |
There was a problem hiding this comment.
Ensure the LOG_LEVEL variable is properly validated to prevent potential command injection or unexpected behavior. Consider adding a check to ensure it only contains expected values (e.g., DEBUG, INFO, WARN).
| @@ -123,11 +123,15 @@ in [entrypoint.sh](https://github.com/nylonee/watchlistarr/blob/main/docker/entr | |||
| | ALLOW_ENDED_SHOW_DELETING | false | Boolean flag to enable/disable the full Watchlistarr sync for ended shows. If enabled, shows that have no more planned seasons and are not watchlisted will be deleted from Sonarr | | |||
| | ALLOW_CONTINUING_SHOW_DELETING | false | Boolean flag to enable/disable the full Watchlistarr sync for continuing shows. If enabled, shows that still have planned seasons and are not watchlisted will be deleted from Sonarr | | |||
| | DELETE_INTERVAL_DAYS | 7 | Number of days to wait before deleting content from the arrs (Deleting must be enabled) | | |||
| | LOG_LEVEL | INFO | Level of logging, set to DEBUG for more verbose logs, or WARN for less logs | | |||
There was a problem hiding this comment.
The addition of the LOG_LEVEL configuration option is well-documented. Ensure that the documentation clearly specifies the acceptable values for LOG_LEVEL and their impact on logging verbosity.
| The Plex Pass subscription is required to generate the RSS Feed URLs. Without a Plex Pass, the normal API calls are too | ||
| heavy-hitting on Plex's servers. | ||
|
|
||
| If the app detects that you are not a Plex Pass user (i.e. the app tries to generate an RSS URL, and it fails), it will | ||
| fall back into a periodic sync. |
There was a problem hiding this comment.
The clarification regarding the necessity of a Plex Pass for generating RSS Feed URLs is helpful. Ensure that the explanation of the fallback mechanism for non-Plex Pass users is clear and concise, possibly by providing an example or more detailed description of how the periodic sync operates.
Closes #84
Summary by CodeRabbit
LOG_LEVELconfiguration to adjust logging verbosity.LOG_LEVELenvironment variable.