feat: key rotation #5777
Open
feat: key rotation #5777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jstuczyn
force-pushed
the
feature/key-rotation
branch
from
ba86a00 to
f5b295c
Compare
jstuczyn
force-pushed
the
feature/key-rotation
branch
from
c107c2c to
d9abe17
Compare
durch
approved these changes
May 22, 2025
There was a problem hiding this comment.
This is all very well thought out and executed. I've got to conceptual comments, or weak points, but nothing that we can address, more something to be vigilant about:
- The config upgrade process, particularly upgrade_sphinx_key, involves network calls and multiple file operations. A failure mid-process could leave the node in a partially upgraded or broken state.
- The KeyRotationController's error handling for failed key/filter operations (that don't poison a mutex) primarily relies on logging. Depending on the failure, this might lead to the node operating with inconsistent keys/filters until the next successful cycle.
jstuczyn
force-pushed
the
feature/key-rotation
branch
4 times, most recently
from
4381eed to
441b55d
Compare
…side the set interval
jstuczyn
force-pushed
the
feature/key-rotation
branch
from
5bb998e to
14f58c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that one was definitely another ecach-size adventure. you can find detailed description on our confluence page
This change is