Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/receive coins page + UI tweaks #704

Merged
merged 12 commits into from
Aug 2, 2021
Merged

Conversation

fmtabbara
Copy link
Contributor

No description provided.

@fmtabbara fmtabbara marked this pull request as ready for review July 28, 2021 08:16
@jstuczyn
Copy link
Contributor

I think you might be trying to squeeze stuff too aggressively, that's how the bond page looks in my browser:
image

@fmtabbara
Copy link
Contributor Author

Good point! I updated the breakpoints so should hopefully be better now! 🤞

@jstuczyn
Copy link
Contributor

At some width it suddenly shrinks:
image

goes into

image

@fmtabbara
Copy link
Contributor Author

Ah OK. I think width for larger screens needs to be increased. I've updated it. See what you think.

@jstuczyn
Copy link
Contributor

jstuczyn commented Aug 2, 2021

There's still a weird sudden shrink at 1920px width, but it's not as bad as it was before. I think it's good enough now : )

@fmtabbara
Copy link
Contributor Author

There'll be a bit of movement as I've added some responsiveness to the pages, which should allow the content to look OK across all screen sizes. I'll have another quick look before merging. Thanks for the feedback ☺️

@fmtabbara fmtabbara merged commit 2904141 into develop Aug 2, 2021
@fmtabbara fmtabbara deleted the feature/receive-coins-page branch August 2, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a wallet user, I would like to have a "receive" page where I can see my own wallet address
2 participants