Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Analytics requires SEOmatic #35

Closed
jdsdev opened this issue Sep 12, 2024 · 2 comments
Closed

Instant Analytics requires SEOmatic #35

jdsdev opened this issue Sep 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jdsdev
Copy link

jdsdev commented Sep 12, 2024

Describe the bug

Instant Analytics requires SEOmatic for some of its functionality, but SEOmatic is not a required dependency. Ideally the two could function as standalone plugins

To reproduce

Steps to reproduce the behaviour:

  1. Install nystudio107/craft-instantanalytics-ga4 but not nystudio107/craft-seomatic.
  2. Create an {{ eventTrackingUrl(URL, EVENT_NAME, PARAMS) }}.
  3. Click the link: Class "nystudio107\seomatic\helpers\Json" not found

Versions

  • Plugin version: 5.0.0
  • Craft version: 5.4.3
@jdsdev jdsdev added the bug Something isn't working label Sep 12, 2024
@khalwat
Copy link
Contributor

khalwat commented Sep 13, 2024

Ah yes, this is definitely a bug.

khalwat added a commit that referenced this issue Sep 14, 2024
@khalwat
fix: Fixed an inadvertant dependency on SEOmatic ([#35](#35))
9c36548
khalwat added a commit that referenced this issue Sep 14, 2024
@khalwat
fix: Fixed an inadvertant dependency on SEOmatic ([#35](#35))
d908602
khalwat added a commit that referenced this issue Sep 14, 2024
@khalwat
fix: Fixed an inadvertant dependency on SEOmatic ([#35](#35))
4bb59a3
@khalwat
Copy link
Contributor

khalwat commented Sep 14, 2024

Released as 5.0.1 -> https://github.com/nystudio107/craft-instantanalytics-ga4/releases/tag/5.0.1

@khalwat khalwat closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdsdev @khalwat