Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify changes to docs #1491

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Clarify changes to docs #1491

merged 2 commits into from
Jul 12, 2024

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented Jul 12, 2024

Fixes a few typos I spotted made in recent changes (jet lag can have that effect ;).

Also, the docs say that:

Normally SEOmatic will invalidate the cache for a sitemap for a Section, Category Group, or Product any time you save an element. However, if you prefer to regenerate the sitemap manually you can set disable the Regenerate Sitemaps Automatically option in SEOmatic’s Plugin Settings.

Does the Regenerate Sitemaps Automatically now just clear the cached sitemap or also regenerate it?

@bencroker bencroker requested a review from khalwat as a code owner July 12, 2024 08:10
@bencroker bencroker changed the title Fix typos in docs Clarify changes to docs Jul 12, 2024
@khalwat
Copy link
Collaborator

khalwat commented Jul 12, 2024

It only invalidates the cache now. There is no more "generation" really, I just left the CLI commands in so people can pre-cache the sitemaps if they want.

The queue job is entirely gone now, it just paginates the sitemaps, and will generate each paginated page on demand.

@khalwat
Copy link
Collaborator

khalwat commented Jul 12, 2024

thx!

@khalwat khalwat merged commit d78e81b into nystudio107:develop-v5 Jul 12, 2024
2 checks passed
@bencroker
Copy link
Contributor Author

It only invalidates the cache now.

That’s what I thought. You may want to rename the setting for clarity, but I’ll leave that to you.

@bencroker bencroker deleted the patch-9 branch July 12, 2024 08:48
@khalwat
Copy link
Collaborator

khalwat commented Jul 12, 2024

Yep, renamed it to "Invalidate Sitemap Caches Automatically" for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants