This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 305
readAll() is not resilient to exceptions reading a single file #293
Comments
Yup sounds like a great solution. Want to pr it in with some tests? |
Cool, thanks. Yes, I will try to do one. |
@digitalbuddha Did you have a chance to look at my PR? |
Was moving. Will look today
…On Dec 4, 2017 4:41 AM, "Ricardo" ***@***.***> wrote:
@digitalbuddha <https://github.com/digitalbuddha> Did you have a chance
to look at my PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#293 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEUX3EeUvNCrYPELk-xfHL_Ih9x1jbAeks5s874sgaJpZM4QohUK>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current
readAll()
implementation inFSAllReader
fails if there is an exception reading a single file in the path. In this code:If an exception occurs on a
fileSystem.read(s)
, then the whole chain will stop with an onError emission preventing us from getting subsequent files on thepath
.One way around it, I think, would be to wrap the read in a
flatMap()
and emit an empty or special type empty buffer. Something like:Then we can let the caller decide what to do with the
ExceptionBuffer
. Would something in this direction work?The text was updated successfully, but these errors were encountered: