update loader to support google maps 3d tiles #39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2009 The Closure Library Authors | ||
| * Copyright 2020 Daniel Wirtz / The long.js Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>A-Frame 3D Tiles Component - Basic example</title> | ||
| <meta name="description" content="Basic example for 3D Tiles component showing google 3d Tiles."></meta> | ||
| <script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script> | ||
| <script src="../../dist/aframe-loader-3dtiles-component.js"></script> | ||
| <!-- <script src="https://unpkg.com/3dstreet@0.4.5/dist/aframe-street-component.js"></script> --> | ||
|
|
||
| <!-- vr teleport controls --> | ||
| <!-- <script src="https://cdn.jsdelivr.net/npm/aframe-blink-controls@0.4.3/dist/aframe-blink-controls.min.js"></script> --> | ||
| <style> | ||
| #guide { | ||
| position: fixed; | ||
| top: 0; | ||
| right: 0; | ||
| width: 300px; | ||
| padding: 1rem 2rem; | ||
| font-family:'Courier New', Courier, monospace; | ||
| line-height: 1.2; | ||
| background-color: white; | ||
| color: black; | ||
| } | ||
|
|
||
| #guide p { | ||
| margin-top: 10px; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <a-scene vr-mode-ui="enabled: false" renderer="colorManagement: true;"> | ||
| <a-entity camera="fov:45; near:1; far: 1000" look-controls="reverseMouseDrag: true" wasd-controls="enabled: true" id="camera" cursor-teleport="cameraRig: #camera; cameraHead: #camera;"></a-entity> | ||
| <a-entity | ||
| id="tileset" | ||
| loader-3dtiles=" | ||
| url: https://tile.googleapis.com/v1/3dtiles/root.json; | ||
| lat: 37.77522354250163; | ||
| long: -122.41931773049723; | ||
| height: -16.5; | ||
| googleApiKey: INSERTYOURKEYHERE; | ||
| geoTransform: WGS84Cartesian; | ||
| maximumSSE: 48; | ||
| maximumMem: 400; | ||
| cameraEl: #camera" | ||
| > | ||
| </a-entity> | ||
| </a-scene> | ||
|
|
||
| <!-- GitHub Corner. --> | ||
| <a href="https://github.com/nytimes/aframe-loader-3dtiles-component" class="github-corner"> | ||
| <svg width="80" height="80" viewBox="0 0 250 250" style="fill:#222; color:#fff; position: absolute; top: 0; border: 0; right: 0;"> | ||
| <path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path><path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" style="transform-origin: 130px 106px;" class="octo-arm"></path><path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path> | ||
| </svg> | ||
| </a> | ||
| <div id="guide"> | ||
| <span id="example-desc"> | ||
| <b>Google 3D Tiles example.</b> | ||
| </span> | ||
| <p>Use arrow/WASD keys to move around and click and drag to turn/rotate the camera.</p> | ||
| <p> | ||
| <u>Available component parameters:</u> | ||
| <ul> | ||
| <li><b>lat, long</b>: coordinates of Google Map.</li> | ||
| <li><b>height</b>: camera height.</li> | ||
| <li><b>googleApiKey</b>: Google Api Key.</li> | ||
| </ul> | ||
| </p> | ||
| </div> | ||
| <script> | ||
| const queryParams = new URLSearchParams(document.location.search); | ||
|
|
||
| if (queryParams.get('tilesetUrl')) { | ||
| document.querySelector('#tileset').addEventListener('object3dset', (e) => { | ||
| e.target.setAttribute('loader-3dtiles', { | ||
| url: queryParams.get('tilesetUrl') | ||
| }) | ||
| }) | ||
| } | ||
| </script> | ||
| <style>.github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}}</style> | ||
| <!-- End GitHub Corner. --> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example demo states that this and also lat/long/height are available parameters but there is no option to insert them via the query string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the expected behavior in this example is only to place tiles with a long / lat / height specified in the index.html centered at scene origin 0 0 0. Supporting a dynamic, user-specified querystring with lat / long / height was not intended to be part of this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
It's maybe OK since the example is anyway not exposed in the demo showcase, but if it works well we should probably consider adding it in the future and also make the example usable without editing the code. Maybe after we have occlusion culling and teleport controls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agreed. I've added these tickets to track: