Copying ESLint config instead of linking. updating with wf-style rules

cli/actions/lint.js

@@ -6,6 +6,7 @@ const CLIEngine = require('eslint').CLIEngine;
 const temp = require('temp');
 const fs = require('fs');
 const merge = require('ramda').merge;
+const shell = require('shelljs');
 const logger = require('./../logger');
 const kytConfig = require('./../../config/kyt.config');
 const baseConfig = require('./../../eslint.json');
@@ -41,25 +42,14 @@ module.exports = () => {
     logger.log(formatter(report.results));
   };
 
-  // In order to support merging a local configFile/eslint.json,
-  // we need to save the result of the merge to a temp file
-  // and point to that. Otherwise, we just use our config.
-  if (kytConfig.eslintConfig) {
-    const config = getConfig(kytConfig.eslintConfig);
-    temp.open('temp-eslintrc-', (error, info) => {
-      if (!error) {
-        fs.write(info.fd, JSON.stringify(config));
-        fs.close(info.fd, logger.error);
-        eslintCLI.configFile = info.path;
-        lint();
-        temp.cleanupSync();
-        logger.info('Using eslint config override');
-      } else {
-        logger.error('Error with user eslint config', error);
-      }
-    });
-  } else {
-    eslintCLI.configFile = path.join(__dirname, '../../eslint.json');
+    const esLintPath = path.join(kytConfig.userRootPath, './eslint.json');
+
+    // Check to see if eslint file exists
+    if (!shell.test('-f', esLintPath)) {
+      logger.error('You do not have an esLint File');
+      logger.info('Run node_modules/.bin kyt setup to get the default eslint config');
+      process.exit();
+    }
+    eslintCLI.configFile = esLintPath;
     lint();
-  }
 };

cli/actions/setup.js

@@ -109,13 +109,13 @@ module.exports = (program) => {
       // Copy over starter-kyt esLint
       if (shell.test('-f', tmpEsLint)) {
         if (shell.cp(tmpEsLint, linkedPath).code === 0 ) {
-          logger.task('Copied esLint config from starter-kyt');
+          logger.task('Copied ESLint config from starter-kyt');
         }
       } else {
-        // Create a symbolic link from our local eslint
+        // Copy our local eslint
         const esLintPath = path.join(userRootPath, 'node_modules/kyt/eslint.json');
-        if (shell.ln('-s', esLintPath, linkedPath).code === 0) {
-          logger.task('Linked esLint config');
+        if (shell.cp(esLintPath, linkedPath).code === 0) {
+          logger.task('Copied kyt default ESLint config');
         }
       }
     };
@@ -197,7 +197,7 @@ module.exports = (program) => {
       }
       // Copy the prototype file from the starter kit into the users repo
       shell.exec(`cp ${starterProto} ${userProto}`);
-      logger.task('copied prototype.js file into root');
+      logger.task('Copied prototype.js file into root');
     };
 
     try {

eslint.json

@@ -9,8 +9,16 @@
     "plugins": [
       "json"
     ],
-
     "rules": {
+      "no-lonely-if": 2,
+      "no-nested-ternary": 2,
+      "max-nested-callbacks": [2, { "max": 5 }],
+      "constructor-super": 2,
+      "no-this-before-super": 2,
+      "prefer-spread": 2,
+      "prefer-reflect": 2,
+      "no-warning-comments": [1, { "terms": ["todo", "fixme"], "location": "start" }],
+      "react/sort-comp": 0,
       "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
       "import/no-unresolved": [2, { "ignore": ["ava"] }],
       "import/no-extraneous-dependencies": [0]