Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: Plugin Support #265

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP/RFC: Plugin Support #265

wants to merge 3 commits into from

Conversation

afischer
Copy link
Member

@afischer afischer commented May 25, 2021

Pushing this very WIP branch to develop out in the open and get comments/suggestions as this is built out!

Description of Change

Adds support for "zero config" plugins that are installed via npm, which can (at this point) do a few things:

  • Export a transform, a function that can modify the HTML content
  • Export a csp to extend the content security policy
  • Export externalScripts/externalStyles to allow for the addition of additional scripts/stylesheets to the <head>
  • More TK! Middleware? Would love to hear your thoughts

In the future, this feature could be expanded to

Related Issue

Closes #249

Motivation and Context

See linked issue: It's currently somewhat cumbersome to add customizations to Library. People have used Docker-based solutions, or simply forked the repo in order to more easily get customizations added to the app.

Checklist

  • Ran npm run lint and updated code style accordingly
  • npm run test passes
  • PR has a description and all contributors/stakeholder are noted/cc'ed
  • tests are updated and/or added to cover new code
  • relevant documentation is changed and/or added

Copy link
Member

@isaacwhite isaacwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall shape & concept here seems really cool! Would be great to get some additional documentation on vision & intended user experience with these, but in general excited for us to be moving in this direction. 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider a "zero config" plugin architecture
2 participants